Bump eslint-plugin-github version + fix eslint issues (#437)

* Bump eslint-plugin-github and eslint rules update

* ban-ts-comment rule was enabled

.eslintrc.json

@@ -1,6 +1,6 @@
 {
-  "plugins": ["jest", "@typescript-eslint"],
+  "plugins": ["jest", "@typescript-eslint", "github"],
-  "extends": ["plugin:github/es6"],
+  "extends": ["plugin:github/recommended"],
   "parser": "@typescript-eslint/parser",
   "parserOptions": {
     "ecmaVersion": 9,
@@ -19,13 +19,17 @@
     "@typescript-eslint/no-require-imports": "error",
     "@typescript-eslint/array-type": "error",
     "@typescript-eslint/await-thenable": "error",
-    "@typescript-eslint/ban-ts-ignore": "error",
+    "@typescript-eslint/ban-ts-comment": "error",
     "camelcase": "off",
-    "@typescript-eslint/camelcase": "error",
+    "@typescript-eslint/naming-convention": [
-    "@typescript-eslint/class-name-casing": "error",
+      "error",
+      {
+        "selector": "default",
+        "format": ["camelCase", "UPPER_CASE", "StrictPascalCase"]
+      }
+    ],
     "@typescript-eslint/explicit-function-return-type": ["error", {"allowExpressions": true}],
     "@typescript-eslint/func-call-spacing": ["error", "never"],
-    "@typescript-eslint/generic-type-naming": ["error", "^[A-Z][A-Za-z]*$"],
     "@typescript-eslint/no-array-constructor": "error",
     "@typescript-eslint/no-empty-interface": "error",
     "@typescript-eslint/no-explicit-any": "off",
@@ -50,7 +54,8 @@
     "@typescript-eslint/semi": ["error", "never"],
     "@typescript-eslint/type-annotation-spacing": "error",
     "@typescript-eslint/unbound-method": "error",
-    "no-console": "off"
+    "no-console": "off",
+    "no-shadow": ["error", { "builtinGlobals": false, "hoist": "all", "allow": ["Status"] }]
   },
   "env": {
     "node": true,

package.json

@@ -42,7 +42,7 @@
     "@types/jest": "26.0.14",
     "@types/node": "14.11.2",
     "eslint": "7.9.0",
-    "eslint-plugin-github": "3.4.1",
+    "eslint-plugin-github": "4.1.1",
     "eslint-plugin-jest": "24.0.2",
     "eslint-plugin-prettier": "^3.1.2",
     "jest": "25.5.4",