adk23333/github-pages-deploy-action
1
0
Fork 0
mirror of https://github.com/JamesIves/github-pages-deploy-action.git synced 2023-12-15 20:03:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix lint scripts (#1154)

Browse Source 
* Fix Prettier script name in docs

* Lint and format all files

* Fix files locally and check files in CI

* Fix unformatted files
This commit is contained in:
Nick McCurdy 2022-06-26 08:57:32 -04:00 committed by GitHub
parent c0e8d739fd
commit d45cebdf6f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.github/workflows/build.yml vendored
View File

@ -27,7 +27,8 @@ jobs:
- name: Install and Test - name: Install and Test
run: | run: |
yarn install --frozen-lockfile yarn install --frozen-lockfile
yarn lint yarn lint:check
yarn lint:format:check
yarn test yarn test
- name: Uploade CodeCov Report - name: Uploade CodeCov Report

2
CONTRIBUTING.md
View File

@ -9,7 +9,7 @@ When contributing to this repository, please first discuss the change you wish t
2. Ensure your change passes all of the integration tests. 2. Ensure your change passes all of the integration tests.
3. Make sure you update the README if you've made a change that requires documentation. 3. Make sure you update the README if you've made a change that requires documentation.
4. When making a pull request, highlight any areas that may cause a breaking change so the maintainer can update the version number accordingly on the GitHub marketplace and package registries. 4. When making a pull request, highlight any areas that may cause a breaking change so the maintainer can update the version number accordingly on the GitHub marketplace and package registries.
5. Make sure you've formatted and linted your code. You can do this by running `yarn format` and `yarn lint`. 5. Make sure you've linted and formatted your code. You can do this by running `yarn lint` and `yarn lint:format`.
6. Fix or add any tests where applicable. You can run `yarn test` to run the suite. As this action is small in scope it's important that a high level of test coverage is maintained. All tests are written using [Jest](https://jestjs.io/). 6. Fix or add any tests where applicable. You can run `yarn test` to run the suite. As this action is small in scope it's important that a high level of test coverage is maintained. All tests are written using [Jest](https://jestjs.io/).
7. As this package is written in [TypeScript](https://www.typescriptlang.org/) please ensure all typing is accurate and the action compiles correctly by running `yarn build`. 7. As this package is written in [TypeScript](https://www.typescriptlang.org/) please ensure all typing is accurate and the action compiles correctly by running `yarn build`.

7
integration/index.html
View File

@ -1,12 +1,13 @@
<!DOCTYPE html> <!DOCTYPE html>
<html> <html>
<head> <head>
<meta charset="UTF-8"> <meta charset="UTF-8" />
<title>Integration Test</title> <title>Integration Test</title>
<meta name="robots" content="noindex" /> <meta name="robots" content="noindex" />
<style> <style>
html, body { html,
body {
height: 100%; height: 100%;
width: 100%; width: 100%;
} }
@ -29,4 +30,4 @@
<body> <body>
<div class="image"></div> <div class="image"></div>
</body> </body>
</html> </html>

6
package.json
View File

@ -9,8 +9,10 @@
"scripts": { "scripts": {
"build": "rimraf lib && tsc --declaration", "build": "rimraf lib && tsc --declaration",
"test": "jest", "test": "jest",
"lint": "eslint src/**/*.ts __tests__/**/*.ts", "lint": "eslint --fix .",
"lint:format": "prettier --write './**/*.{ts,js,json,yml,md}' './*.{ts,js,json,yml,md}'" "lint:check": "eslint .",
"lint:format": "prettier --write .",
"lint:format:check": "prettier --check ."
}, },
"repository": { "repository": {
"type": "git", "type": "git",