2020-03-07 11:45:40 +08:00
|
|
|
/**
|
|
|
|
* @fileoverview Disallows or enforces spaces inside of parentheses.
|
|
|
|
* @author Jonathan Rajavuori
|
|
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
|
2020-03-31 20:40:00 +08:00
|
|
|
const astUtils = require("./utils/ast-utils");
|
2020-03-07 11:45:40 +08:00
|
|
|
|
|
|
|
//------------------------------------------------------------------------------
|
|
|
|
// Rule Definition
|
|
|
|
//------------------------------------------------------------------------------
|
|
|
|
|
|
|
|
module.exports = {
|
|
|
|
meta: {
|
|
|
|
type: "layout",
|
|
|
|
|
|
|
|
docs: {
|
|
|
|
description: "enforce consistent spacing inside parentheses",
|
|
|
|
category: "Stylistic Issues",
|
|
|
|
recommended: false,
|
|
|
|
url: "https://eslint.org/docs/rules/space-in-parens"
|
|
|
|
},
|
|
|
|
|
|
|
|
fixable: "whitespace",
|
|
|
|
|
|
|
|
schema: [
|
|
|
|
{
|
|
|
|
enum: ["always", "never"]
|
|
|
|
},
|
|
|
|
{
|
|
|
|
type: "object",
|
|
|
|
properties: {
|
|
|
|
exceptions: {
|
|
|
|
type: "array",
|
|
|
|
items: {
|
|
|
|
enum: ["{}", "[]", "()", "empty"]
|
|
|
|
},
|
|
|
|
uniqueItems: true
|
|
|
|
}
|
|
|
|
},
|
|
|
|
additionalProperties: false
|
|
|
|
}
|
2020-03-31 20:40:00 +08:00
|
|
|
],
|
|
|
|
|
|
|
|
messages: {
|
|
|
|
missingOpeningSpace: "There must be a space after this paren.",
|
|
|
|
missingClosingSpace: "There must be a space before this paren.",
|
|
|
|
rejectedOpeningSpace: "There should be no space after this paren.",
|
|
|
|
rejectedClosingSpace: "There should be no space before this paren."
|
|
|
|
}
|
2020-03-07 11:45:40 +08:00
|
|
|
},
|
|
|
|
|
|
|
|
create(context) {
|
2020-03-31 20:40:00 +08:00
|
|
|
const ALWAYS = context.options[0] === "always",
|
2020-03-07 11:45:40 +08:00
|
|
|
exceptionsArrayOptions = (context.options[1] && context.options[1].exceptions) || [],
|
|
|
|
options = {};
|
2020-03-31 20:40:00 +08:00
|
|
|
|
2020-03-07 11:45:40 +08:00
|
|
|
let exceptions;
|
|
|
|
|
|
|
|
if (exceptionsArrayOptions.length) {
|
2020-03-31 20:40:00 +08:00
|
|
|
options.braceException = exceptionsArrayOptions.includes("{}");
|
|
|
|
options.bracketException = exceptionsArrayOptions.includes("[]");
|
|
|
|
options.parenException = exceptionsArrayOptions.includes("()");
|
|
|
|
options.empty = exceptionsArrayOptions.includes("empty");
|
2020-03-07 11:45:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Produces an object with the opener and closer exception values
|
|
|
|
* @returns {Object} `openers` and `closers` exception values
|
|
|
|
* @private
|
|
|
|
*/
|
|
|
|
function getExceptions() {
|
|
|
|
const openers = [],
|
|
|
|
closers = [];
|
|
|
|
|
|
|
|
if (options.braceException) {
|
|
|
|
openers.push("{");
|
|
|
|
closers.push("}");
|
|
|
|
}
|
|
|
|
|
|
|
|
if (options.bracketException) {
|
|
|
|
openers.push("[");
|
|
|
|
closers.push("]");
|
|
|
|
}
|
|
|
|
|
|
|
|
if (options.parenException) {
|
|
|
|
openers.push("(");
|
|
|
|
closers.push(")");
|
|
|
|
}
|
|
|
|
|
|
|
|
if (options.empty) {
|
|
|
|
openers.push(")");
|
|
|
|
closers.push("(");
|
|
|
|
}
|
|
|
|
|
|
|
|
return {
|
|
|
|
openers,
|
|
|
|
closers
|
|
|
|
};
|
|
|
|
}
|
|
|
|
|
|
|
|
//--------------------------------------------------------------------------
|
|
|
|
// Helpers
|
|
|
|
//--------------------------------------------------------------------------
|
|
|
|
const sourceCode = context.getSourceCode();
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Determines if a token is one of the exceptions for the opener paren
|
|
|
|
* @param {Object} token The token to check
|
|
|
|
* @returns {boolean} True if the token is one of the exceptions for the opener paren
|
|
|
|
*/
|
|
|
|
function isOpenerException(token) {
|
2020-03-31 20:40:00 +08:00
|
|
|
return exceptions.openers.includes(token.value);
|
2020-03-07 11:45:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Determines if a token is one of the exceptions for the closer paren
|
|
|
|
* @param {Object} token The token to check
|
|
|
|
* @returns {boolean} True if the token is one of the exceptions for the closer paren
|
|
|
|
*/
|
|
|
|
function isCloserException(token) {
|
2020-03-31 20:40:00 +08:00
|
|
|
return exceptions.closers.includes(token.value);
|
2020-03-07 11:45:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2020-03-31 20:40:00 +08:00
|
|
|
* Determines if an opening paren is immediately followed by a required space
|
|
|
|
* @param {Object} openingParenToken The paren token
|
|
|
|
* @param {Object} tokenAfterOpeningParen The token after it
|
|
|
|
* @returns {boolean} True if the opening paren is missing a required space
|
2020-03-07 11:45:40 +08:00
|
|
|
*/
|
2020-03-31 20:40:00 +08:00
|
|
|
function openerMissingSpace(openingParenToken, tokenAfterOpeningParen) {
|
|
|
|
if (sourceCode.isSpaceBetweenTokens(openingParenToken, tokenAfterOpeningParen)) {
|
2020-03-07 11:45:40 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2020-03-31 20:40:00 +08:00
|
|
|
if (!options.empty && astUtils.isClosingParenToken(tokenAfterOpeningParen)) {
|
|
|
|
return false;
|
2020-03-07 11:45:40 +08:00
|
|
|
}
|
|
|
|
|
2020-03-31 20:40:00 +08:00
|
|
|
if (ALWAYS) {
|
|
|
|
return !isOpenerException(tokenAfterOpeningParen);
|
|
|
|
}
|
|
|
|
return isOpenerException(tokenAfterOpeningParen);
|
2020-03-07 11:45:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2020-03-31 20:40:00 +08:00
|
|
|
* Determines if an opening paren is immediately followed by a disallowed space
|
|
|
|
* @param {Object} openingParenToken The paren token
|
|
|
|
* @param {Object} tokenAfterOpeningParen The token after it
|
|
|
|
* @returns {boolean} True if the opening paren has a disallowed space
|
2020-03-07 11:45:40 +08:00
|
|
|
*/
|
2020-03-31 20:40:00 +08:00
|
|
|
function openerRejectsSpace(openingParenToken, tokenAfterOpeningParen) {
|
|
|
|
if (!astUtils.isTokenOnSameLine(openingParenToken, tokenAfterOpeningParen)) {
|
2020-03-07 11:45:40 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2020-03-31 20:40:00 +08:00
|
|
|
if (tokenAfterOpeningParen.type === "Line") {
|
2020-03-07 11:45:40 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2020-03-31 20:40:00 +08:00
|
|
|
if (!sourceCode.isSpaceBetweenTokens(openingParenToken, tokenAfterOpeningParen)) {
|
|
|
|
return false;
|
2020-03-07 11:45:40 +08:00
|
|
|
}
|
|
|
|
|
2020-03-31 20:40:00 +08:00
|
|
|
if (ALWAYS) {
|
|
|
|
return isOpenerException(tokenAfterOpeningParen);
|
|
|
|
}
|
|
|
|
return !isOpenerException(tokenAfterOpeningParen);
|
2020-03-07 11:45:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2020-05-15 05:33:08 +08:00
|
|
|
* Determines if a closing paren is immediately preceded by a required space
|
2020-03-31 20:40:00 +08:00
|
|
|
* @param {Object} tokenBeforeClosingParen The token before the paren
|
|
|
|
* @param {Object} closingParenToken The paren token
|
|
|
|
* @returns {boolean} True if the closing paren is missing a required space
|
2020-03-07 11:45:40 +08:00
|
|
|
*/
|
2020-03-31 20:40:00 +08:00
|
|
|
function closerMissingSpace(tokenBeforeClosingParen, closingParenToken) {
|
|
|
|
if (sourceCode.isSpaceBetweenTokens(tokenBeforeClosingParen, closingParenToken)) {
|
2020-03-07 11:45:40 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2020-03-31 20:40:00 +08:00
|
|
|
if (!options.empty && astUtils.isOpeningParenToken(tokenBeforeClosingParen)) {
|
2020-03-07 11:45:40 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ALWAYS) {
|
2020-03-31 20:40:00 +08:00
|
|
|
return !isCloserException(tokenBeforeClosingParen);
|
2020-03-07 11:45:40 +08:00
|
|
|
}
|
2020-03-31 20:40:00 +08:00
|
|
|
return isCloserException(tokenBeforeClosingParen);
|
2020-03-07 11:45:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2020-05-15 05:33:08 +08:00
|
|
|
* Determines if a closer paren is immediately preceded by a disallowed space
|
2020-03-31 20:40:00 +08:00
|
|
|
* @param {Object} tokenBeforeClosingParen The token before the paren
|
|
|
|
* @param {Object} closingParenToken The paren token
|
|
|
|
* @returns {boolean} True if the closing paren has a disallowed space
|
2020-03-07 11:45:40 +08:00
|
|
|
*/
|
2020-03-31 20:40:00 +08:00
|
|
|
function closerRejectsSpace(tokenBeforeClosingParen, closingParenToken) {
|
|
|
|
if (!astUtils.isTokenOnSameLine(tokenBeforeClosingParen, closingParenToken)) {
|
2020-03-07 11:45:40 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2020-03-31 20:40:00 +08:00
|
|
|
if (!sourceCode.isSpaceBetweenTokens(tokenBeforeClosingParen, closingParenToken)) {
|
2020-03-07 11:45:40 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ALWAYS) {
|
2020-03-31 20:40:00 +08:00
|
|
|
return isCloserException(tokenBeforeClosingParen);
|
2020-03-07 11:45:40 +08:00
|
|
|
}
|
2020-03-31 20:40:00 +08:00
|
|
|
return !isCloserException(tokenBeforeClosingParen);
|
2020-03-07 11:45:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
//--------------------------------------------------------------------------
|
|
|
|
// Public
|
|
|
|
//--------------------------------------------------------------------------
|
|
|
|
|
|
|
|
return {
|
|
|
|
Program: function checkParenSpaces(node) {
|
|
|
|
exceptions = getExceptions();
|
|
|
|
const tokens = sourceCode.tokensAndComments;
|
|
|
|
|
|
|
|
tokens.forEach((token, i) => {
|
|
|
|
const prevToken = tokens[i - 1];
|
|
|
|
const nextToken = tokens[i + 1];
|
|
|
|
|
2020-03-31 20:40:00 +08:00
|
|
|
// if token is not an opening or closing paren token, do nothing
|
2020-03-07 11:45:40 +08:00
|
|
|
if (!astUtils.isOpeningParenToken(token) && !astUtils.isClosingParenToken(token)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2020-03-31 20:40:00 +08:00
|
|
|
// if token is an opening paren and is not followed by a required space
|
|
|
|
if (token.value === "(" && openerMissingSpace(token, nextToken)) {
|
2020-03-07 11:45:40 +08:00
|
|
|
context.report({
|
|
|
|
node,
|
2020-03-31 20:40:00 +08:00
|
|
|
loc: token.loc,
|
|
|
|
messageId: "missingOpeningSpace",
|
2020-03-07 11:45:40 +08:00
|
|
|
fix(fixer) {
|
|
|
|
return fixer.insertTextAfter(token, " ");
|
|
|
|
}
|
|
|
|
});
|
2020-03-31 20:40:00 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// if token is an opening paren and is followed by a disallowed space
|
|
|
|
if (token.value === "(" && openerRejectsSpace(token, nextToken)) {
|
2020-03-07 11:45:40 +08:00
|
|
|
context.report({
|
|
|
|
node,
|
2020-03-31 20:40:00 +08:00
|
|
|
loc: { start: token.loc.end, end: nextToken.loc.start },
|
|
|
|
messageId: "rejectedOpeningSpace",
|
2020-03-07 11:45:40 +08:00
|
|
|
fix(fixer) {
|
|
|
|
return fixer.removeRange([token.range[1], nextToken.range[0]]);
|
|
|
|
}
|
|
|
|
});
|
2020-03-31 20:40:00 +08:00
|
|
|
}
|
2020-03-07 11:45:40 +08:00
|
|
|
|
2020-03-31 20:40:00 +08:00
|
|
|
// if token is a closing paren and is not preceded by a required space
|
|
|
|
if (token.value === ")" && closerMissingSpace(prevToken, token)) {
|
2020-03-07 11:45:40 +08:00
|
|
|
context.report({
|
|
|
|
node,
|
2020-03-31 20:40:00 +08:00
|
|
|
loc: token.loc,
|
|
|
|
messageId: "missingClosingSpace",
|
2020-03-07 11:45:40 +08:00
|
|
|
fix(fixer) {
|
|
|
|
return fixer.insertTextBefore(token, " ");
|
|
|
|
}
|
|
|
|
});
|
2020-03-31 20:40:00 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// if token is a closing paren and is preceded by a disallowed space
|
|
|
|
if (token.value === ")" && closerRejectsSpace(prevToken, token)) {
|
2020-03-07 11:45:40 +08:00
|
|
|
context.report({
|
|
|
|
node,
|
2020-03-31 20:40:00 +08:00
|
|
|
loc: { start: prevToken.loc.end, end: token.loc.start },
|
|
|
|
messageId: "rejectedClosingSpace",
|
2020-03-07 11:45:40 +08:00
|
|
|
fix(fixer) {
|
|
|
|
return fixer.removeRange([prevToken.range[1], token.range[0]]);
|
|
|
|
}
|
|
|
|
});
|
|
|
|
}
|
|
|
|
});
|
|
|
|
}
|
|
|
|
};
|
|
|
|
}
|
|
|
|
};
|