2020-03-07 11:45:40 +08:00
|
|
|
/**
|
|
|
|
* @fileoverview Rule to flag use of implied eval via setTimeout and setInterval
|
|
|
|
* @author James Allardice
|
|
|
|
*/
|
|
|
|
|
|
|
|
"use strict";
|
|
|
|
|
2020-05-15 05:33:08 +08:00
|
|
|
//------------------------------------------------------------------------------
|
|
|
|
// Requirements
|
|
|
|
//------------------------------------------------------------------------------
|
|
|
|
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
const { getStaticValue } = require("eslint-utils");
|
|
|
|
|
2020-03-07 11:45:40 +08:00
|
|
|
//------------------------------------------------------------------------------
|
|
|
|
// Rule Definition
|
|
|
|
//------------------------------------------------------------------------------
|
|
|
|
|
|
|
|
module.exports = {
|
|
|
|
meta: {
|
|
|
|
type: "suggestion",
|
|
|
|
|
|
|
|
docs: {
|
|
|
|
description: "disallow the use of `eval()`-like methods",
|
|
|
|
category: "Best Practices",
|
|
|
|
recommended: false,
|
|
|
|
url: "https://eslint.org/docs/rules/no-implied-eval"
|
|
|
|
},
|
|
|
|
|
2020-05-15 05:33:08 +08:00
|
|
|
schema: [],
|
|
|
|
|
|
|
|
messages: {
|
|
|
|
impliedEval: "Implied eval. Consider passing a function instead of a string."
|
|
|
|
}
|
2020-03-07 11:45:40 +08:00
|
|
|
},
|
|
|
|
|
|
|
|
create(context) {
|
2020-05-15 05:33:08 +08:00
|
|
|
const EVAL_LIKE_FUNCS = Object.freeze(["setTimeout", "execScript", "setInterval"]);
|
|
|
|
const GLOBAL_CANDIDATES = Object.freeze(["global", "window", "globalThis"]);
|
2020-03-07 11:45:40 +08:00
|
|
|
|
|
|
|
/**
|
2020-05-15 05:33:08 +08:00
|
|
|
* Checks whether a node is evaluated as a string or not.
|
|
|
|
* @param {ASTNode} node A node to check.
|
|
|
|
* @returns {boolean} True if the node is evaluated as a string.
|
2020-03-07 11:45:40 +08:00
|
|
|
*/
|
2020-05-15 05:33:08 +08:00
|
|
|
function isEvaluatedString(node) {
|
|
|
|
if (
|
|
|
|
(node.type === "Literal" && typeof node.value === "string") ||
|
|
|
|
node.type === "TemplateLiteral"
|
|
|
|
) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
if (node.type === "BinaryExpression" && node.operator === "+") {
|
|
|
|
return isEvaluatedString(node.left) || isEvaluatedString(node.right);
|
|
|
|
}
|
|
|
|
return false;
|
2020-03-07 11:45:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2020-05-15 05:33:08 +08:00
|
|
|
* Checks whether a node is an Identifier node named one of the specified names.
|
|
|
|
* @param {ASTNode} node A node to check.
|
|
|
|
* @param {string[]} specifiers Array of specified name.
|
|
|
|
* @returns {boolean} True if the node is a Identifier node which has specified name.
|
2020-03-07 11:45:40 +08:00
|
|
|
*/
|
2020-05-15 05:33:08 +08:00
|
|
|
function isSpecifiedIdentifier(node, specifiers) {
|
|
|
|
return node.type === "Identifier" && specifiers.includes(node.name);
|
2020-03-07 11:45:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2020-05-15 05:33:08 +08:00
|
|
|
* Checks a given node is a MemberExpression node which has the specified name's
|
|
|
|
* property.
|
|
|
|
* @param {ASTNode} node A node to check.
|
|
|
|
* @param {string[]} specifiers Array of specified name.
|
|
|
|
* @returns {boolean} `true` if the node is a MemberExpression node which has
|
|
|
|
* the specified name's property
|
2020-03-07 11:45:40 +08:00
|
|
|
*/
|
2020-05-15 05:33:08 +08:00
|
|
|
function isSpecifiedMember(node, specifiers) {
|
|
|
|
return node.type === "MemberExpression" && specifiers.includes(astUtils.getStaticPropertyName(node));
|
2020-03-07 11:45:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2020-05-15 05:33:08 +08:00
|
|
|
* Reports if the `CallExpression` node has evaluated argument.
|
|
|
|
* @param {ASTNode} node A CallExpression to check.
|
|
|
|
* @returns {void}
|
2020-03-07 11:45:40 +08:00
|
|
|
*/
|
2020-05-15 05:33:08 +08:00
|
|
|
function reportImpliedEvalCallExpression(node) {
|
|
|
|
const [firstArgument] = node.arguments;
|
|
|
|
|
|
|
|
if (firstArgument) {
|
2020-03-07 11:45:40 +08:00
|
|
|
|
2020-05-15 05:33:08 +08:00
|
|
|
const staticValue = getStaticValue(firstArgument, context.getScope());
|
|
|
|
const isStaticString = staticValue && typeof staticValue.value === "string";
|
|
|
|
const isString = isStaticString || isEvaluatedString(firstArgument);
|
|
|
|
|
|
|
|
if (isString) {
|
|
|
|
context.report({
|
|
|
|
node,
|
|
|
|
messageId: "impliedEval"
|
|
|
|
});
|
|
|
|
}
|
|
|
|
}
|
2020-03-07 11:45:40 +08:00
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2020-05-15 05:33:08 +08:00
|
|
|
* Reports calls of `implied eval` via the global references.
|
|
|
|
* @param {Variable} globalVar A global variable to check.
|
|
|
|
* @returns {void}
|
2020-03-07 11:45:40 +08:00
|
|
|
*/
|
2020-05-15 05:33:08 +08:00
|
|
|
function reportImpliedEvalViaGlobal(globalVar) {
|
|
|
|
const { references, name } = globalVar;
|
2020-03-07 11:45:40 +08:00
|
|
|
|
2020-05-15 05:33:08 +08:00
|
|
|
references.forEach(ref => {
|
|
|
|
const identifier = ref.identifier;
|
|
|
|
let node = identifier.parent;
|
2020-03-07 11:45:40 +08:00
|
|
|
|
2020-05-15 05:33:08 +08:00
|
|
|
while (isSpecifiedMember(node, [name])) {
|
|
|
|
node = node.parent;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (isSpecifiedMember(node, EVAL_LIKE_FUNCS)) {
|
|
|
|
const parent = node.parent;
|
|
|
|
|
|
|
|
if (parent.type === "CallExpression" && parent.callee === node) {
|
|
|
|
reportImpliedEvalCallExpression(parent);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
});
|
2020-03-07 11:45:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
//--------------------------------------------------------------------------
|
|
|
|
// Public
|
|
|
|
//--------------------------------------------------------------------------
|
|
|
|
|
|
|
|
return {
|
|
|
|
CallExpression(node) {
|
2020-05-15 05:33:08 +08:00
|
|
|
if (isSpecifiedIdentifier(node.callee, EVAL_LIKE_FUNCS)) {
|
|
|
|
reportImpliedEvalCallExpression(node);
|
2020-03-07 11:45:40 +08:00
|
|
|
}
|
|
|
|
},
|
2020-05-15 05:33:08 +08:00
|
|
|
"Program:exit"() {
|
|
|
|
const globalScope = context.getScope();
|
2020-03-07 11:45:40 +08:00
|
|
|
|
2020-05-15 05:33:08 +08:00
|
|
|
GLOBAL_CANDIDATES
|
|
|
|
.map(candidate => astUtils.getVariableByName(globalScope, candidate))
|
|
|
|
.filter(globalVar => !!globalVar && globalVar.defs.length === 0)
|
|
|
|
.forEach(reportImpliedEvalViaGlobal);
|
2020-03-07 11:45:40 +08:00
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
}
|
|
|
|
};
|